Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrNoChange check when using Up. #336

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

Glyphack
Copy link

Since not checking ErrNoChange on Up function could cause errors and I encountered it. I updated this code to help others.
#100

@Glyphack Glyphack changed the title Add ErrNoChange check when using Up. https://github.com/golang-migrat… Add ErrNoChange check when using Up. Feb 11, 2020
@Glyphack Glyphack requested a review from dhui February 11, 2020 21:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 668

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.382%

Totals Coverage Status
Change from base Build 667: 0.0%
Covered Lines: 2496
Relevant Lines: 4765

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 668

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.382%

Totals Coverage Status
Change from base Build 667: 0.0%
Covered Lines: 2496
Relevant Lines: 4765

💛 - Coveralls

@dhui
Copy link
Member

dhui commented Feb 12, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants