sqlite3: Allow users to disable implicit transactions #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An sqlite3 database may be opened with the x-no-tx-wrap=true query parameter if the user would prefer to retain full control over the bounds of their transactions. With x-no-tx-wrap enabled, migrations should contain explicit BEGIN and COMMIT statements. This (optional) behaviour for the sqlite3 driver is consistent with the default behaviour for other drivers. Fixes #346.
Pull Request Test Coverage Report for Build 707
💛 - Coveralls |
dhui
requested changes
Feb 29, 2020
database/sqlite3/sqlite3.go
Outdated
|
|
||
| noTxWrap, err := strconv.ParseBool(qv.Get("x-no-tx-wrap")) | ||
| if err != nil { | ||
| noTxWrap = false |
There was a problem hiding this comment.
It's cleaner to return an error for invalid values. We should handle non-existent (e.g. unspecified) values separately.
There was a problem hiding this comment.
I did wonder about this, so I went looking for existing patterns. I found this behaviour in the cockroachdb driver. Would you still prefer an error -- at the cost of consistency -- in this case?
There was a problem hiding this comment.
Yeah, it's cleaner to fail for invalid inputs instead of silently assuming a value
There was a problem hiding this comment.
I have pushed a commit with the change you requested. PTAL, @dhui.
dhui
approved these changes
Mar 3, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346.