Adding support for schema management in snowflake #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhui Any more comments on this one ? I had closed the earlier pull request as I had by mistake pushed 2 commits in that one. |
dhui
requested changes
Jun 3, 2020
| |------------|---------------------|-------------| | ||
| | `x-migrations-table` | `MigrationsTable` | Name of the migrations table | | ||
|
|
||
| Snowflake is PostgreSQL compatible but has some specific features (or lack thereof) that require slightly different behavior. |
There was a problem hiding this comment.
Add a note about Snowflake not being officially supported since there aren't any tests.
If you'd like, you can also link to this driver in top-level README, but you don't have to.
There was a problem hiding this comment.
Added a line saying that Snowflake cant be made to run locally.
database/snowflake/snowflake.go
Outdated
| @@ -0,0 +1,373 @@ | |||
| // +build go1.12 | |||
Ran it. |
|
Build is failing with go1.14 due to some issues with mssql/server testing. |
|
@dhui any more changes needed ? Or else we can merge ? |
|
@dhui Possible to create another tag? Last one was 4.11.0 in April which doesn't contain these changes. |
|
Released v4.12.0 with these changes |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to close the earlier pull request as I had by mistake pushed 2 commits.
However I have addressed the comments in that pull request.
Link for the earlier pull request.
added any tests. However I have tested manually against my private snowflake hosted instance.