-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spanner): resolve "want scalar type" error #427
Conversation
also ran a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, fix, and regression test!
Let's wait until there's an official release/tag. Also, don't forget to run go mod tidy
.
Yes, I did run a |
@dhui: 1.9.0 is out now. Updated the PR as well as the commit message and PR bodies. https://pkg.go.dev/cloud.google.com/go/spanner?tab=doc |
This one seems to often be the cause of the flaky test in CI (in go 1.13) the couple of times I checked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for tests to pass before merging
- Update spanner library to cloud.google.com/go/spanner@v1.9.0 This prevents erroring on DDL statements like: ALTER TABLE users ALTER COLUMN created SET OPTIONS (allow_commit_timestamp = true); googleapis/google-cloud-go#2656 - Add test case which fails with older version of the library, and succeeds with this one. Fixes: #426
This prevents erroring on DDL statements like:
googleapis/google-cloud-go#2656
Fixes: #426