Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): resolve "want scalar type" error #427

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix(spanner): resolve "want scalar type" error #427

merged 1 commit into from
Aug 19, 2020

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Aug 15, 2020

  • Update spanner library to cloud.google.com/go/spanner@v1.9.0

This prevents erroring on DDL statements like:

ALTER TABLE users ALTER COLUMN created                                   
  SET OPTIONS (allow_commit_timestamp = true);                           

googleapis/google-cloud-go#2656

  • Add test case which fails with older version of the library, and succeeds with this one.

Fixes: #426

@coveralls
Copy link

coveralls commented Aug 15, 2020

Pull Request Test Coverage Report for Build 838

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.29%

Totals Coverage Status
Change from base Build 835: 0.0%
Covered Lines: 2640
Relevant Lines: 4954

💛 - Coveralls

@wyardley
Copy link
Contributor Author

also ran a go mod tidy based on feedback in other PRs, let me know if that doesn't look right.

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, fix, and regression test!

Let's wait until there's an official release/tag. Also, don't forget to run go mod tidy.

@wyardley
Copy link
Contributor Author

Yes, I did run a go mod tidy ☝️
FWIW, this does totally fix the issue w/ the newer version. I'll try to harass them to release a new one this coming week, because I'd like to be able to use this soon.

@wyardley
Copy link
Contributor Author

@dhui: 1.9.0 is out now. Updated the PR as well as the commit message and PR bodies.

https://pkg.go.dev/cloud.google.com/go/spanner?tab=doc
also ran go mod tidy though doesn't seem to have pulled much out

@wyardley wyardley requested a review from dhui August 19, 2020 02:10
@wyardley
Copy link
Contributor Author

--- FAIL: Test (0.00s)
    --- FAIL: Test/mcr.microsoft.com/mssql/server:2019-latest (120.01s)
        dktest.go:36: Pulling image: mcr.microsoft.com/mssql/server:2019-latest
        dktest.go:54: Error parsing image pull response: context deadline exceeded
        dktest.go:186: Failed to run image: mcr.microsoft.com/mssql/server:2019-latest error: Error response from daemon: No such image: mcr.microsoft.com/mssql/server:2019-

This one seems to often be the cause of the flaky test in CI (in go 1.13) the couple of times I checked.

dhui
dhui previously approved these changes Aug 19, 2020
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for tests to pass before merging

- Update spanner library to cloud.google.com/go/spanner@v1.9.0
This prevents erroring on DDL statements like:

ALTER TABLE users ALTER COLUMN created
  SET OPTIONS (allow_commit_timestamp = true);
googleapis/google-cloud-go#2656

- Add test case which fails with older version of the library, and
succeeds with this one.

Fixes: #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spansql error (want scalar type)
3 participants