Update driver.go #454
Merged
Update driver.go #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 897
💛 - Coveralls |
dhui
reviewed
Oct 8, 2020
source/driver.go
Outdated
| @@ -87,7 +87,7 @@ func Open(url string) (Driver, error) { | |||
| d, ok := drivers[u.Scheme] | |||
| driversMu.RUnlock() | |||
| if !ok { | |||
| return nil, fmt.Errorf("source driver: unknown driver %v (forgotten import?)", u.Scheme) | |||
| return nil, fmt.Errorf("source driver: unknown driver '%v' (forgotten import?)", u.Scheme) | |||
There was a problem hiding this comment.
Might as well make it '%s' while you're at it
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled upon the
source driver: unknown driver file (forgotten import?)error which has been reported as an issue multiple times.This is a tiny proposal that might make the error message more readable:
instead of
source driver: unknown driver file (forgotten import?), the message can besource driver: unknown driver 'file' (forgotten import?)to indicate that 'file' is the type of the driver