Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check iterator error on Drop where applicable #456

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

hypnoglow
Copy link
Contributor

Fixes #432

@coveralls
Copy link

coveralls commented Oct 10, 2020

Pull Request Test Coverage Report for Build 885

  • 8 of 24 (33.33%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 55.639%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/cockroachdb/cockroachdb.go 1 3 33.33%
database/firebird/firebird.go 1 3 33.33%
database/mysql/mysql.go 1 3 33.33%
database/postgres/postgres.go 1 3 33.33%
database/ql/ql.go 1 3 33.33%
database/redshift/redshift.go 1 3 33.33%
database/sqlcipher/sqlcipher.go 1 3 33.33%
database/sqlite3/sqlite3.go 1 3 33.33%
Totals Coverage Status
Change from base Build 883: -0.1%
Covered Lines: 3044
Relevant Lines: 5471

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql.Rows.Next() not followed by Rows.Err()
3 participants