Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

len(k) is guaranteed to be greater than 1 in this case #664

Merged
merged 2 commits into from Dec 8, 2021

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Dec 7, 2021

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1548222526

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.738%

Totals Coverage Status
Change from base Build 1497266502: 0.0%
Covered Lines: 3731
Relevant Lines: 6462

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the test for this to add a 2 letter query param key and ensure that the the expected params are not filtered?

Besides that, this change LGTM.

Thanks for the PR!

@suzaku
Copy link
Contributor Author

suzaku commented Dec 8, 2021

Can you update the test for this to add a 2 letter query param key and ensure that the the expected params are not filtered?

Besides that, this change LGTM.

Thanks for the PR!

Fixed.

@dhui dhui merged commit 0c500eb into golang-migrate:master Dec 8, 2021
@suzaku suzaku deleted the simplify branch December 8, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants