Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose configuring cassandra connect timeout through query string #708

Merged
merged 1 commit into from Feb 22, 2022

Conversation

taywrobel
Copy link
Contributor

@taywrobel taywrobel commented Feb 19, 2022

Exposes the cassandra client's ConnectTimeout parameter through
the cassandra database query string.

The Cassandra client has a fairly aggressive connect timeout of
600ms, which can cause flakiness in certain network environments
or in Cassandra-compatible clusters with a more complex process
for establishing connections (i.e. ScyllaDB).

The query timeout is already configurable and exposed, but does
not impact the connect timeout in the gocql driver. This change
allows for configurtion of both.

Exposes the cassandra client's ConnectTimeout parameter through
the cassandra database query string.

The Cassandra client has a fairly aggressive connect timeout of
600ms, which can cause flakiness in certain network environments
or in Cassandra-compatible clusters with a more complex process
for establishing connections (i.e. ScyllaDB).

The query timeout is already configurable and exposed, but does
not impact the connect timeout in the gocql driver. This change
allows for configurtion of both.
@coveralls
Copy link

@coveralls coveralls commented Feb 19, 2022

Pull Request Test Coverage Report for Build 1867225512

  • 1 of 7 (14.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 57.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/cassandra/cassandra.go 1 7 14.29%
Totals Coverage Status
Change from base Build 1821224966: -0.05%
Covered Lines: 3732
Relevant Lines: 6462

💛 - Coveralls

dhui
dhui approved these changes Feb 22, 2022
Copy link
Member

@dhui dhui left a comment

Thanks for the PR!

@dhui dhui merged commit e1d604b into golang-migrate:master Feb 22, 2022
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants