Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump up CI version & fix CI failed #810

Merged
merged 1 commit into from
Oct 5, 2022
Merged

bump up CI version & fix CI failed #810

merged 1 commit into from
Oct 5, 2022

Conversation

linzhengen
Copy link
Contributor

@linzhengen linzhengen commented Sep 19, 2022 •
edited

I found many pull requests CI failed. to fix it.

  • bump actions/checkout@v2 to actions/checkout@v3
  • bump golangci/golangci-lint-action@v2 to golangci/golangci-lint-action@v3
  • bump actions/setup-go@v2 to actions/setup-go@v3
  • use go1.19 to fix go fmt
    • why
      • golangci-lint is using go v1.19 for gofmt linter inspite. reference
    • what I did
      • go1.19 fmt ./...

@coveralls
Copy link

coveralls commented Sep 19, 2022 •
edited

Coverage Status

Coverage remained the same at 57.91% when pulling 30deade on linzhengen:bump_ci_version into 2d1de76 on golang-migrate:master.

@linzhengen linzhengen changed the title bump CI version bump up CI version & fix CI failed Sep 19, 2022
@linzhengen linzhengen marked this pull request as ready for review September 19, 2022 11:11
@acim acim mentioned this pull request Sep 21, 2022
Closed
@xrn
Copy link

xrn commented Oct 5, 2022

@dhui any chance for merge? Plus are you planning any release soon?

dhui
dhui approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates & fixes!

@dhui dhui merged commit 37a9174 into golang-migrate:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@linzhengen @coveralls @xrn @dhui