Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CockroachDB tutorial's link being relative to 'GETTING_STARTED.md' #819

Merged
merged 2 commits into from Oct 19, 2022
Merged

Fix CockroachDB tutorial's link being relative to 'GETTING_STARTED.md' #819

merged 2 commits into from Oct 19, 2022

Conversation

Nintron27
Copy link
Contributor

Fix the link root so that it doesn't point relatively. Currently the link points to /blob/master/database/cockroachdb/GETTING_STARTED.md while it should be pointing to /blob/master/GETTING_STARTED.md#create-migrations

@Nintron27
Fix link root
1a60552 
Fix the link root so that it doesn't point relatively.
@Nintron27
Simplify to just the / root
06ffa67
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.91% when pulling 06ffa67 on isaacfolmsbee:patch-1 into 37a9174 on golang-migrate:master.

dhui
dhui approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@dhui dhui merged commit 5ff4dc8 into golang-migrate:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nintron27 @coveralls @dhui