Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): support for dropping row deletion policy #845

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

toga4
Copy link
Contributor

@toga4 toga4 commented Oct 28, 2022

Closes #844

@coveralls
Copy link

coveralls commented Oct 28, 2022

Coverage Status

coverage: 58.572% (+0.05%) from 58.526% when pulling 460c2e0 on toga4:spanner-row-deletion-policy-drop-support into 856ea12 on golang-migrate:master.

@toga4
Copy link
Contributor Author

toga4 commented Nov 10, 2022

The spannertest module lacks some features, making it hard to increase coverage.
So I changed unit testing code to use spanner-emulator on docker in place of spannertest module.

@toga4 toga4 force-pushed the spanner-row-deletion-policy-drop-support branch from f2ac90d to ac32ef3 Compare November 10, 2022 01:06
@toga4
Copy link
Contributor Author

toga4 commented Dec 28, 2022

@dhui sorry for the ping but any chance you could take a look at this?

@toga4 toga4 force-pushed the spanner-row-deletion-policy-drop-support branch from a644f07 to 741afb0 Compare July 3, 2023 22:48
@toga4 toga4 force-pushed the spanner-row-deletion-policy-drop-support branch from 741afb0 to f1afc78 Compare July 3, 2023 22:54
@toga4
Copy link
Contributor Author

toga4 commented Jul 3, 2023

rebased from latest master and fixed lint issue.

@dhui could you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropping spanner tables which has row deletion policy
2 participants