Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for scylladb. add scylladb to docs #947

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

mkorolyov
Copy link
Contributor

Migrate works with Cassandra so it should work with ScyllaDB too as it is a drop-in replacement.

I've checked this and all works fine. Added Cassandra like tests for ScyllaDB and updated docs.

@mkorolyov
Copy link
Contributor Author

@Fontinalis Hey, could you pls take a look into this one?

@guy9
Copy link

guy9 commented Jul 11, 2023

I'm also interested in this

@mixellent
Copy link

+1

1 similar comment
@annastuchlik
Copy link

+1

@coveralls
Copy link

coveralls commented Jul 11, 2023

Coverage Status

coverage: 59.051%. remained the same
when pulling 1d1cd48 on mkorolyov:scylladb_support
into 90c5015 on golang-migrate:master.

Fontinalis
Fontinalis previously approved these changes Jul 11, 2023
Copy link
Member

@Fontinalis Fontinalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution!

@dhui dhui merged commit eb64ffa into golang-migrate:master Dec 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants