New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stable Func keys in App Engine second gen #184
Conversation
Question about requirements: does this need to preserve compatibility with a previous scheme for encoding function names? If not, then may I suggesting using the value of |
Unfortunately, yes. The scheme is described here: #122 (comment) |
Gotcha, that was the context I was missing. I'll review with that in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're on the right track here now that I understand the issue more fully. Since we are codifying something that is kinda fragile to begin with, I want to make sure we proceed carefully.
…g appengine.Main is called directly from main.main
+1, and more generally, we should be very relaxed with any guarantee for this package. It's inherently flaky, and people should know that going in. |
How should I document that? @broady |
Package-level doc, maybe? I think it's in the docs on cloud.google.com somewhere, but fairly hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please wait for @broady's approval.
Fixes #122