main_vm.go: Listen on localhost for dev_appserver; Avoid Mac Firewall #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the Mac OS X firewall asks if _ah_exe should accept incoming network connections, since by default it listens on all interfaces. For development purposes, it is sufficient to only listen on localhost.
|
@broady What do you think about this? (Also, how can we manually request the CLA check for a PR? 😁) |
|
Yeah, I think this is fine. I actually think this fix is perfect - requests actually don't go straight through to the Go binary, they are routed via dev_appserver, which you can change to listen on other network interfaces/IPs via the flags. As noted, I do think we should always listen on 127.0.0.1 rather than ::1 And 👍 manually verified CLA. |
broady
reviewed
Jan 12, 2017
| if err := http.ListenAndServe(":"+port, http.HandlerFunc(handleHTTP)); err != nil { | ||
| host := "" | ||
| if IsDevAppServer() { | ||
| host = "[::1]" |
|
I screwed this up: I think I deleted my original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the Mac OS X firewall asks if _ah_exe should accept incoming
network connections, since by default it listens on all interfaces. For
development purposes, it is sufficient to only listen on localhost.
This is really annoying when working on Go App Engine projects.
This fix is probably not perfect:
I'd be happy to help make both of these changes, if help is wanted.