Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2/search #297

Merged
merged 2 commits into from Mar 16, 2023
Merged

Add v2/search #297

merged 2 commits into from Mar 16, 2023

Conversation

Deleplace
Copy link
Contributor

Integrating the Search legacy bundled service in the appengine/v2 client.

The source is the same as v1:

# Copy the Search source files into v2
cp -R ./appengine/search ./appengine/v2/
cp -R ./appengine/internal/search ./appengine/v2/internal

# Fix import paths
sed -i "" "s/\"google.golang.org\/appengine/\"google.golang.org\/appengine\/v2/" ./appengine/v2/search/search.go
sed -i "" "s/\"google.golang.org\/appengine/\"google.golang.org\/appengine\/v2/" ./appengine/v2/search/search_test.go
sed -i "" "s/\"google.golang.org\/appengine/\"google.golang.org\/appengine\/v2/" ./appengine/v2/internal/search/search.pb.go

@Deleplace
Copy link
Contributor Author

CC @ludoch

Copy link
Collaborator

@ludoch ludoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can you also change the copyright year and license text in missing files( proto for example)?

@Deleplace
Copy link
Contributor Author

Done

@jama22
Copy link

jama22 commented Feb 10, 2023

FWIW, I'd be hesitant to merge this PR in without knowing more about the future of Search API

@ludoch
Copy link
Collaborator

ludoch commented Feb 24, 2023

Valentin, the plan for adding search has now be approved. we can proceed with this PR.
Thanks for your patience and help there.

@Deleplace
Copy link
Contributor Author

Awesome, please review and merge

@ludoch
Copy link
Collaborator

ludoch commented Mar 15, 2023

Valentin, do you know more about the commits that need to be signed? Is it on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants