Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dev_appserver.py usage #302

Closed
wants to merge 1 commit into from

Conversation

MontyCarter
Copy link

It seems like github actions switched to python3 because devappserver.py no longer runs, and complains with python2 not found.

https://github.blog/changelog/2020-02-27-github-actions-breaking-change-python-2-being-removed-from-all-virtual-environments/

actions/setup-python#543 (comment)

python2 support will not be added to ubuntu 22.04, it seems.

It seems like github actions switched to python3 because devappserver.py
no longer runs, and complains with python2 not found.

https://github.blog/changelog/2020-02-27-github-actions-breaking-change-python-2-being-removed-from-all-virtual-environments/

actions/setup-python#543 (comment)

python2 support will not be added to ubuntu 22.04, it seems.
@jinglundong
Copy link
Collaborator

I couldn't tell for sure if we use dev_appserver.py in other places in this repo. From my scan of https://github.com/golang/appengine/search?p=1&q=dev_appserver, this PR is okay.

I approved the workflow run (because this is your first PR I assume). Let's see if workflows pass this time.

@jinglundong
Copy link
Collaborator

Tests failed. @MontyCarter

@jinglundong
Copy link
Collaborator

jinglundong commented Mar 1, 2023

It's still dev_appserver related.

=== RUN   TestBasicAPICalls
ERROR: (dev_appserver) python2: command not found
    instance_test.go:24: NewInstance: unable to find admin server URL
--- FAIL: TestBasicAPICalls (1.63s)
=== RUN   TestContext
ERROR: (dev_appserver) python2: command not found
    instance_test.go:75: NewContext: unable to find admin server URL
--- FAIL: TestContext (0.46s)
=== RUN   TestUsers
ERROR: (dev_appserver) python2: command not found
    instance_test.go:88: NewInstance: unable to find admin server URL
--- FAIL: TestUsers (0.47s)
FAIL
coverage: 41.6% of statements
FAIL	google.golang.org/appengine/aetest	2.595s

Copy link
Collaborator

@ludoch ludoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather try to make devappserver work again.

IIUC, the new base image used for tests does not include python2, so we need to install it so it can be used by the devappserver.

@ludoch
Copy link
Collaborator

ludoch commented Mar 15, 2023

Not needed anymore if we merge #304

@ludoch ludoch closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants