New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acme/autocert: fix TLS-ALPN identifier in tests #117
Conversation
golang#91 broke autocert tests because of the new OID this should bring the changes in line with master.
This PR (HEAD: 77e8d1f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/218941 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/218941. |
Message from Filippo Valsorda: Patch Set 3: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/218941. |
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=07dcd683 Please don’t reply on this GitHub thread. Visit golang.org/cl/218941. |
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/218941. |
CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1f GitHub-Pull-Request: #117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This PR is being closed because golang.org/cl/218941 has been merged. |
CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef GitHub-Pull-Request: golang/crypto#117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef GitHub-Pull-Request: golang/crypto#117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef GitHub-Pull-Request: golang/crypto#117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef GitHub-Pull-Request: golang/crypto#117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1f GitHub-Pull-Request: golang#117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL 204177 broke autocert tests because they expected the old OID.
Fixes golang/go#37160