Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptobyte: AddUint*LengthPrefixed API perfomance optimization #228

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mateusz834
Copy link
Member

@mateusz834 mateusz834 commented Sep 5, 2022

benchmark old ns/op new ns/op delta
BenchmarkLengthPrefixed-4 1345 265 -80.27%

benchmark old allocs new allocs delta
BenchmarkLengthPrefixed-4 17 1 -94.12%

benchmark old bytes new bytes delta
BenchmarkLengthPrefixed-4 777 64 -91.76%

Fixes golang/go#54059

@gopherbot
Copy link
Contributor

This PR (HEAD: dcd2ecc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/428475 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 5dbe5c7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/428475 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: a633e5f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/428475 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants