Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Commit

Permalink
Fix ignored per-project prune options (#1561)
Browse files Browse the repository at this point in the history
* Use prune options defined per-project when generating gps.RootPruneOptions
* Add test cases checking if this behavior is correct
  • Loading branch information
speijnik committed Jan 24, 2018
1 parent 6d95d0d commit b13d6aa
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 3 deletions.
6 changes: 3 additions & 3 deletions manifest.go
Original file line number Diff line number Diff line change
Expand Up @@ -403,13 +403,13 @@ func fromRawPruneOptions(raw rawPruneOptions) gps.RootPruneOptions {
pr := gps.ProjectRoot(p.Name)
opts.ProjectOptions[pr] = gps.PruneNestedVendorDirs

if raw.UnusedPackages {
if p.UnusedPackages {
opts.ProjectOptions[pr] |= gps.PruneUnusedPackages
}
if raw.GoTests {
if p.GoTests {
opts.ProjectOptions[pr] |= gps.PruneGoTestFiles
}
if raw.NonGoFiles {
if p.NonGoFiles {
opts.ProjectOptions[pr] |= gps.PruneNonGoFiles
}
}
Expand Down
63 changes: 63 additions & 0 deletions manifest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,69 @@ func TestValidateProjectRoots(t *testing.T) {
}
}

func TestFromRawPruneOptions(t *testing.T) {
cases := []struct {
name string
rawPruneOptions rawPruneOptions
wantOptions gps.RootPruneOptions
}{
{
name: "global all options project no options",
rawPruneOptions: rawPruneOptions{
UnusedPackages: true,
NonGoFiles: true,
GoTests: true,
Projects: []rawPruneProjectOptions{
{
Name: "github.com/golang/dep/gps",
UnusedPackages: false,
NonGoFiles: false,
GoTests: false,
},
},
},
wantOptions: gps.RootPruneOptions{
PruneOptions: 15,
ProjectOptions: gps.PruneProjectOptions{
"github.com/golang/dep/gps": 1,
},
},
},
{
name: "global no options project all options",
rawPruneOptions: rawPruneOptions{
UnusedPackages: false,
NonGoFiles: false,
GoTests: false,
Projects: []rawPruneProjectOptions{
{
Name: "github.com/golang/dep/gps",
UnusedPackages: true,
NonGoFiles: true,
GoTests: true,
},
},
},
wantOptions: gps.RootPruneOptions{
PruneOptions: 1,
ProjectOptions: gps.PruneProjectOptions{
"github.com/golang/dep/gps": 15,
},
},
},
}

for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
opts := fromRawPruneOptions(c.rawPruneOptions)

if !reflect.DeepEqual(opts, c.wantOptions) {
t.Fatalf("rawPruneOptions are not as expected:\n\t(GOT) %v\n\t(WNT) %v", opts, c.wantOptions)
}
})
}
}

func TestToRawPruneOptions(t *testing.T) {
cases := []struct {
name string
Expand Down

0 comments on commit b13d6aa

Please sign in to comment.