This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Lock file location and add test coverage and doc for LoadProject #198
Comments
Yup, that's definitely a bug - the manifest and lock should always be colocated in the same directory. (I think about it as the manifest defining the location of the root, then the lock and vendor being derived from there)
I was going to say that we might want it in a separate place somewhere, but now that |
tro3
pushed a commit
to tro3/dep
that referenced
this issue
Jan 31, 2017
…scending lock file bug fixed
tro3
pushed a commit
to tro3/dep
that referenced
this issue
Jan 31, 2017
zbintliff
added a commit
to zbintliff/dep
that referenced
this issue
Mar 3, 2017
…scending lock file bug fixed
zbintliff
added a commit
to zbintliff/dep
that referenced
this issue
Mar 3, 2017
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this issue
May 10, 2017
…scending lock file bug fixed
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this issue
May 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Spinning off a specific case from #41.
While adding a unit test for Ctx.LoadProject, I found that in the case where the lock file is in the same directory as the manifest but the dirtree had to be ascended to find it, the lock will not be loaded. If the lock file is always located alongside the manifest, this is a bug and I can fix alongside the test additions. Just let me know.
Also, I assume we want the doc in the docstring, or is there another location? Thx.
The text was updated successfully, but these errors were encountered: