Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Lock file location and add test coverage and doc for LoadProject #198

Closed
tro3 opened this issue Jan 31, 2017 · 1 comment
Closed

Lock file location and add test coverage and doc for LoadProject #198

tro3 opened this issue Jan 31, 2017 · 1 comment

Comments

@tro3
Copy link
Contributor

tro3 commented Jan 31, 2017

Spinning off a specific case from #41.

While adding a unit test for Ctx.LoadProject, I found that in the case where the lock file is in the same directory as the manifest but the dirtree had to be ascended to find it, the lock will not be loaded. If the lock file is always located alongside the manifest, this is a bug and I can fix alongside the test additions. Just let me know.

Also, I assume we want the doc in the docstring, or is there another location? Thx.

@sdboyer
Copy link
Member

sdboyer commented Jan 31, 2017

Yup, that's definitely a bug - the manifest and lock should always be colocated in the same directory. (I think about it as the manifest defining the location of the root, then the lock and vendor being derived from there)

Also, I assume we want the doc in the docstring, or is there another location? Thx.

I was going to say that we might want it in a separate place somewhere, but now that LoadProject is exported (after #178), I think the docstring is plenty for now.

tro3 pushed a commit to tro3/dep that referenced this issue Jan 31, 2017
tro3 pushed a commit to tro3/dep that referenced this issue Jan 31, 2017
sdboyer pushed a commit that referenced this issue Feb 1, 2017
@sdboyer sdboyer closed this as completed in 6411f9e Feb 1, 2017
zbintliff added a commit to zbintliff/dep that referenced this issue Mar 3, 2017
zbintliff added a commit to zbintliff/dep that referenced this issue Mar 3, 2017
ibrasho pushed a commit to ibrasho-forks/dep that referenced this issue May 10, 2017
ibrasho pushed a commit to ibrasho-forks/dep that referenced this issue May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants