New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Masterminds/semver to latest 2.x (deal w/non-pointer Version) #562

Closed
sdboyer opened this Issue May 11, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@sdboyer
Copy link
Member

sdboyer commented May 11, 2017

We've been lagging behind on our semver dependency for a while now. The main reason is, back in January, i made a PR that 'depointerized' semver.Version objects - Masterminds/semver#27 - but never quite finished adapting gps to rely on the new value-based patterns. Doing this is now a prerequisite for #225, which is part of our manifest/lock stabilization milestone, so we gotta get it done.

I did start in on the conversion, and I remember running into some slightly annoying things, but nothing terrible. It does involve at least looking through some of the more complicated parts of gps' internals, but I don't think it will be horrible to do - I suspect that someone looking to help out could basically do the following:

  1. Update dep's semver dependency to the latest 2.x (dep ensure -update)
  2. Fix the resulting compile errors
  3. Search for any other places dep's code directly references semver.Version and make sure they seem sane

And get [almost] the whole way there. If something weird does come up, we can discuss as it goes along.

@xmattstrongx

This comment has been minimized.

Copy link
Contributor

xmattstrongx commented May 11, 2017

Ill take this on 👍

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented May 18, 2017

Fixed by #579.

@sdboyer sdboyer closed this May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment