Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Rearrange path validation to allow ports #1509

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

sttts
Copy link

@sttts sttts commented Jan 8, 2018

Rebase of #1160

@sttts sttts requested a review from sdboyer as a code owner January 8, 2018 10:22
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@sttts
Copy link
Author

sttts commented Jan 10, 2018

@sdboyer anything else you want for this change?

@sttts
Copy link
Author

sttts commented Jan 10, 2018

Have to look into the CI errors, something around bzr.

@jmank88
Copy link
Collaborator

jmank88 commented Jan 10, 2018

The AppVeyor bzr failures are pre-existing. I restarted the hung 1.8.x Travis job.

@sdboyer sdboyer added this to the v0.4.0 milestone Jan 15, 2018
Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine to eat the cost of unnecessarily rerunning that regex all the time for now. it's a much lower cost than the refactor otherwise required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants