Feature/flag to disable help text #477
Conversation
|
The flag needs to be on |
|
Oh wait, looking at these more...ugh, yeah, because we still have #454 to deal with, those other commands are still writing the manifest. Uggghhhhhh. Let's put this on hold for a second until we can resolve that. Sorry 😦 |
|
@sdboyer Ensure and remove both use |
|
Okay, not a problem :) |
|
I just submitted a fix so that only |
|
yep, should be ready to move this ahead |
|
Ace! Thanks! I'll make those changes shortly |
… text if noExample is false
|
All passing :) |
txn_writer.go
Outdated
| @@ -320,9 +320,16 @@ func (sw *SafeWriter) Write(root string, sm gps.SourceManager) error { | |||
| return errors.Wrap(err, "failed to marshal manifest to TOML") | |||
| } | |||
|
|
|||
| initOutput := "" | |||
There was a problem hiding this comment.
nit: more idiomatic to do this as var initOutput string
|
We do need to make sure this is covered by tests. Fortunately, there's an easy mechanism, there - for all the tests under Once you make the change, you'll need to run cool? |
|
I was going to ask how the tests work actually, that's perfect, I'll go through those now |
…riable instantiation
|
@EwanValentine Ah, so what you did covers the newly-added logic, which is great. But I was looking for a bit more; I was hoping you'd go through the existing tests and add |
|
Apologies, yeah I see what you mean now, will update shortly |
|
@sdboyer hopefully this is what you mean |
|
@EwanValentine yep, that's exactly what i was going for. Thanks, in we go! 🎉 |
…ble-help-text Feature/flag to disable help text
No description provided.