Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Add a FAQ about how to contribute to dependencies #755

Merged

Conversation

ibrasho
Copy link
Collaborator

@ibrasho ibrasho commented Jun 14, 2017

What does this do / why do we need it?

Added a FAQ about how to test changes to dependencies.
Also, reorder the FAQs to group related questions.

What should your reviewer look out for in this PR?

Ensure that FAQ grouping actually makes sense.

Also reorder the FAQs to group related questions.

Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carolynvs carolynvs merged commit 3312000 into golang:master Jun 14, 2017
@ibrasho ibrasho deleted the faq-contributing-to-vendored-package branch June 15, 2017 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants