slices: add ContainsFunc function #39

GRbit · 2022-07-13T13:00:07Z

Since we have Index, IndexFunc, and Contains functions, it's logical to have ContainsFunc function as well.

Fixes #53983

gopherbot · 2022-07-13T13:00:50Z

This PR (HEAD: 7554eb1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/417374 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-07-13T13:59:23Z

Message from Ian Lance Taylor:

Patch Set 1: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-13T13:59:23Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

earthboundkid · 2022-07-29T17:46:37Z

slices/slices.go

@@ -128,6 +128,12 @@ func Contains[E comparable](s []E, v E) bool {
 	return Index(s, v) >= 0
 }

+// ContainsFunc reports whether at least one element in s
+// satisfies f(s[*]).
+func ContainsFunc[E comparable](s []E, f func(E) bool) bool {


This should be E any to match IndexFunc, no?

You are absolutely correct, thank you!

gopherbot · 2022-08-02T08:50:46Z

This PR (HEAD: 8923cee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/417374 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-11-30T23:19:14Z

Message from Ian Lance Taylor:

Patch Set 2: -Hold

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-01T07:27:46Z

Message from Pavel Griaznov:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-01T16:58:53Z

Message from Brad Fitzpatrick:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-01T17:20:21Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-01T17:20:22Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-01T21:06:03Z

This PR (HEAD: 96a32b3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/417374 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-12-01T21:11:39Z

Message from Pavel Griaznov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-01T23:59:50Z

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-02T07:36:30Z

This PR (HEAD: b7f6091) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/417374 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-12-02T07:41:46Z

Message from Pavel Griaznov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:14:18Z

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:18:44Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:18:45Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:18:46Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:23:16Z

Message from Ian Lance Taylor:

Patch Set 6: Patch Set 5 was rebased

Outdated Votes:

Run-TryBot+1 (copy condition: "changekind:NO_CODE_CHANGE")
TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE")

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:23:16Z

Message from Ian Lance Taylor:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:27:51Z

Message from Gopher Robot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:27:51Z

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T04:27:52Z

Message from Ian Lance Taylor:

Patch Set 6: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-12-03T17:43:49Z

Message from Brad Fitzpatrick:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/417374.
After addressing review feedback, remember to publish your drafts!

Since we have Index, IndexFunc, and Contains functions, it's logical to have ContainsFunc function as well. Fixes #53983 Change-Id: I1237d43bd93927d38b51e3e9ce5386b9098049f7 GitHub-Last-Rev: b7f6091 GitHub-Pull-Request: #39 Reviewed-on: https://go-review.googlesource.com/c/exp/+/417374 Run-TryBot: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com>

gopherbot · 2022-12-05T20:48:49Z

This PR is being closed because golang.org/cl/417374 has been merged.

GRbit mentioned this pull request Jul 21, 2022

x/exp/slices: add ContainsFunc golang/go#53983

Closed

earthboundkid reviewed Jul 29, 2022

View reviewed changes

GRbit force-pushed the master branch from 7554eb1 to 8923cee Compare August 2, 2022 08:48

GRbit force-pushed the master branch from 8923cee to 96a32b3 Compare December 1, 2022 21:01

slices: add ContainsFunc function

b7f6091

GRbit force-pushed the master branch from 96a32b3 to b7f6091 Compare December 2, 2022 07:35

gopherbot closed this Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

slices: add ContainsFunc function #39

slices: add ContainsFunc function #39

GRbit commented Jul 13, 2022 •

edited

gopherbot commented Jul 13, 2022

gopherbot commented Jul 13, 2022

gopherbot commented Jul 13, 2022

earthboundkid Jul 29, 2022

GRbit Aug 2, 2022

gopherbot commented Aug 2, 2022

gopherbot commented Nov 30, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 2, 2022

gopherbot commented Dec 2, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 5, 2022

slices: add ContainsFunc function #39

slices: add ContainsFunc function #39

Conversation

GRbit commented Jul 13, 2022 • edited

gopherbot commented Jul 13, 2022

gopherbot commented Jul 13, 2022

gopherbot commented Jul 13, 2022

earthboundkid Jul 29, 2022

Choose a reason for hiding this comment

GRbit Aug 2, 2022

Choose a reason for hiding this comment

gopherbot commented Aug 2, 2022

gopherbot commented Nov 30, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 1, 2022

gopherbot commented Dec 2, 2022

gopherbot commented Dec 2, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 3, 2022

gopherbot commented Dec 5, 2022

GRbit commented Jul 13, 2022 •

edited