This repository has been archived by the owner on Jan 16, 2021. It is now read-only.
Make github credentials compulsory to avoid bad deployments #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if cred.ClientID == "" || cred.ClientSecret == "" { | ||
| log.Fatal("secret.json needs to define ClientID and ClientSecret") | ||
| } | ||
| return fmt.Sprintf("client_id=%s&client_secret=%s", cred.ClientID, cred.ClientSecret) |
There was a problem hiding this comment.
Do the values need to be escaped via url.QueryEscape, or are they guaranteed to never use any symbols that might need escaping?
There was a problem hiding this comment.
it should not make a difference if the value is escaped or not
There was a problem hiding this comment.
You should probably use url.Values and then its Encode method to create this string.
|
I think this PR should remove the |
|
PTAL |
|
LGTM. |
| @@ -33,7 +33,7 @@ func init() { | |||
| } | |||
|
|
|||
| var ( | |||
| contactEmail = "golang-dev@googlegroups.com" | |||
| contactEmail = "unknown@example.com" | |||
There was a problem hiding this comment.
changed by mistake - removed now
adg
added a commit
that referenced
this pull request
Jul 1, 2015
Make github credentials compulsory to avoid bad deployments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time I deployed I forgot to set the github credentials causing random failures (403).
I don't want this happening again.