Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppc64le - TestPredicatesRobustSignEqualities failure due to floating point precision differences #86

Closed
prashantkhoje opened this issue May 30, 2022 · 1 comment
Closed

ppc64le - TestPredicatesRobustSignEqualities failure due to floating point precision differences #86

prashantkhoje opened this issue May 30, 2022 · 1 comment

Comments

@prashantkhoje
Copy link

I ran tests on ppc64le using "go test -v ./..." command.

The TestPredicatesRobustSignEqualities fails due to floating point precision differences:

=== RUN   TestPredicatesRobustSignEqualities
    predicates_test.go:130: Testing equality for RobustSign. (0.577350269189625731058868, 0.577350269189625731058868, 0.577350269189625731058868) = (0.577350269189625842081171, 0.577350269189625842081171, 0.577350269189625842081171), got false want true
--- FAIL: TestPredicatesRobustSignEqualities (0.00s)

[root@buildvm geo]# go env
GO111MODULE=""
GOARCH="ppc64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="ppc64le"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_ppc64le"
GOVCS=""
GOVERSION="go1.17.7"
GCCGO="gccgo"
GOPPC64="power8"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/root/go/src/github.com/geo/geo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build193501898=/tmp/go-build -gno-record-gcc-switches"

[root@buildvm geo]# git branch
* master
@prashantkhoje prashantkhoje changed the title ppc64le - TestPredicatesRobustSignEqualities failure ppc64le - TestPredicatesRobustSignEqualities failure due to floating point precision differences May 30, 2022
prashantkhoje added a commit to prashantkhoje/geo that referenced this issue Jun 14, 2022
@prashantkhoje
Fix floating point failures seen on ppc64le
b12e9c3 
Fixes test failures:
    - TestClosestEdgeQueryTrueDistanceLessThanChordAngleDistance (golang#88)
    - TestPointMeasuresPointArea (golang#87)
    - TestPredicatesRobustSignEqualities (golang#86)
@prashantkhoje prashantkhoje mentioned this issue Jun 14, 2022
Closed
prashantkhoje added a commit to prashantkhoje/geo that referenced this issue Jun 14, 2022
@prashantkhoje
Fix the floating point failures seen on ppc64le
2295cbe 
Fixes test failures:
    - TestClosestEdgeQueryTrueDistanceLessThanChordAngleDistance (golang#88)
    - TestPointMeasuresPointArea (golang#87)
    - TestPredicatesRobustSignEqualities (golang#86)
@Philiphil Philiphil mentioned this issue Nov 18, 2022
Merged
@rsned
Copy link
Collaborator

rsned commented Apr 21, 2023

This should be fixed as part of commit eee7799

@rsned rsned closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsned @prashantkhoje