cmd/gc: incorrect error message

[davecheney]

The following incorrect program

package main

func f(a, b string, bool) bool {
        return true
}

func main() {
        println(f(true))
}

produces this error message when compiled

lucky(~/src) % go build q.go                                                                                                                                    
# command-line-arguments
./q.go:3: final function parameter must have type

Which I believe is wrong, the final parameter does have a type, bool, what is lacks is a name.

[josharian]

gc thinks that bool is the name. Related: #10579

[minux]

Yeah, gc's meesage is still correct, just unintuitive. Go's type names are not keywords, so it's hard to give intuitive error messages here. For example, "func f(bool bool) bool { return bool }" is a correct Go definition. http://play.golang.org/p/4LtgjmRoGm (I'm wandering whether func bool(bool bool) bool is correct....)

[josharian]

It makes for a fun error message: http://play.golang.org/p/WiAk8ktzxK

[ianlancetaylor]

Not sure how we can do better here.