Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover, x/tools/cover: Remember current file in Go Cover when reloading #11388

Closed
tgrosinger opened this issue Jun 24, 2015 · 3 comments
Closed
Assignees
Milestone

Comments

@tgrosinger
Copy link

@tgrosinger tgrosinger commented Jun 24, 2015

Go Version: 1.4.2 linux/amd64
Operating System: Ubuntu
What did you do: Run GoCover and view HTML report, switch file, then refresh page
What did you expect: Update the report with newest version, but remain on selected file
What did actually happened: Updated the report with newest version, but returned to alphabetically first file.

In the HTML UI for Go Cover, remember what page the user was viewing when the page is refreshed. This is useful when builds are being run automatically and the user wants to see what has changed in the coverage report.

This was originally a discussion I started in the Golang-Nuts forum.

@tgrosinger
Copy link
Author

@tgrosinger tgrosinger commented Jun 24, 2015

Let me know if this issue belongs elsewhere. I didn't see a separate issue tracker for the gocover tool

@mikioh mikioh changed the title Remember current file in Go Cover when reloading cmd/cover, x/tools/cover: Remember current file in Go Cover when reloading Jun 25, 2015
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jul 11, 2015
@robpike robpike assigned adg and unassigned robpike Jul 13, 2015
@robpike
Copy link
Contributor

@robpike robpike commented Jul 13, 2015

Assigning to @adg, who wrote the UI. If it's easy to fix, that would be fine with me, but if it requires a lot of work it wouldn't be worthwhile.

@dherbst
Copy link

@dherbst dherbst commented Mar 10, 2016

This appears to be resolved with 98abf29 in go1.6. Nice!

@adg adg closed this Mar 11, 2016
@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.