Skip to content

x/tools/cmd/goimports: external package is preferred over package level variable  #12180

@mgenov

Description

@mgenov

In db.go

package api

type Stat struct {
}

type DB struct {
    Stats *Stat
}

var (
    store = &DB{&Stat{}}
)

In stats.go

package api

// this line is imported by goimports automatically, where it shouldn't 
import "github.com/coreos/etcd/store" 

func takeStats() {
    s := store.Stats

    s = nil
}

go version go1.5rc1 darwin/amd64
Tools revision: 9f2124f (HEAD)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions