Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path/filepath: GlobEscape function #13516

Closed
ekisu opened this issue Dec 7, 2015 · 2 comments
Closed

path/filepath: GlobEscape function #13516

ekisu opened this issue Dec 7, 2015 · 2 comments

Comments

@ekisu
Copy link

ekisu commented Dec 7, 2015

Sometimes, when using Glob, valid filepaths are mistakenly understood as a expression (e.g. paths with [] or ?). Python, as of 3.4, has a glob.escape function to avoid that.

@rakyll rakyll changed the title filepath.GlobEscape function path/filepath: GlobEscape function Dec 7, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/18034 mentions this issue.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Dec 21, 2015
@mvdan
Copy link
Member

mvdan commented Jan 11, 2018

The CL above was closed more than a year ago by @rsc. Quoting him:

  • Glob is built on top of Match; this is really an escaper for Match.
  • It's unclear we want to add new API here.
  • There is no escaping at all on Windows, making this even more dubious.

I'm going to close this for now, as I understand that the rejection was meant for the new API proposal rather than for the patch itself.

If you would like to propose this addition again (or a similar one), please use the proposal process: https://github.com/golang/proposal

@mvdan mvdan closed this as completed Jan 11, 2018
@golang golang locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants