Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof.go references "runtime.panic", which is actually called "runtime.gopanic" #14315

Closed
ohler opened this issue Feb 12, 2016 · 4 comments
Closed

Comments

@ohler
Copy link

ohler commented Feb 12, 2016

printStackRecord in src/runtime/pprof/pprof.go has a reference to "runtime.panic" that looks like it needs updating, since that function was renamed to "runtime.gopanic".

Or perhaps the feature is unimportant and can be deleted; I only found the problem by grepping the code and don't know what the practical consequences are. I grepped in go1.6rc2, but this probably broke somewhere around 1.4.

(I mentioned this problem in #5832 (comment) but am filing a separate bug to make sure it doesn't get lost.)

/cc @aclements

@aclements
Copy link
Member

Dup of #13857. (I already have a CL to fix this [with a test!] in my pile to send when the tree reopens, so no worries about it getting lost.)

@ohler
Copy link
Author

ohler commented Feb 12, 2016

just to be absolutely clear, you saw that this bug is about pprof.go, while #13857 is about traceback.go, right? Fixing them in the same CL sounds fine to me; but it's not a dup, just a similar bug in two places.

@aclements
Copy link
Member

Oh! Sorry, I had in fact missed that. But I do fix both in the CL.

@aclements aclements reopened this Feb 12, 2016
@gopherbot
Copy link

CL https://golang.org/cl/19492 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants