Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: StdSizes needs to know about new complex64 alignment #17584

Closed
mdempsky opened this issue Oct 25, 2016 · 4 comments
Closed

go/types: StdSizes needs to know about new complex64 alignment #17584

mdempsky opened this issue Oct 25, 2016 · 4 comments
Assignees
Milestone

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Oct 25, 2016

golang.org/cl/19800 changed complex64's alignment on 64-bit platforms from 8 to 4. I originally didn't think go/types.StdSizes needed to care about this because of past discussion about StdSizes vs cmd/compile on #12886, but @josharian pointed out cmd/vet relies on StdSizes for validating x+NN(FP) assembly addresses.

/cc @griesemer

@mdempsky mdempsky added this to the Go1.8 milestone Oct 25, 2016
@mdempsky mdempsky self-assigned this Oct 25, 2016
@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 25, 2016

We should probably provide a GCSizes (better name welcome) that matches cmd/compile exactly and that's the one all clients use that depend on the same size computations as cmd/compile.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2016

CL https://golang.org/cl/31939 mentions this issue.

Loading

@josharian
Copy link
Contributor

@josharian josharian commented Oct 25, 2016

We should probably provide a GCSizes

SGTM. Filed #17586 for that. Thanks, @mdempsky, for fixing this in the meantime.

Loading

@RLH
Copy link
Contributor

@RLH RLH commented Oct 25, 2016

GC means garbage collector. gc means go compiler. It is unfortunate but it is what it is. We really need another name for this.

Loading

@gopherbot gopherbot closed this in 213ee3d Oct 25, 2016
@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants