Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/xml: improve package based on the suggestions from metalinter #21578

Closed
pazderak opened this Issue Aug 23, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@pazderak
Copy link
Contributor

pazderak commented Aug 23, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go1.8.3 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/admin/go-workspace"
GORACE=""
GOROOT="/opt/go"
GOTOOLDIR="/opt/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build725687701=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

I run metalinter tool in the encoding/xml package and I saw bunch of errors and warnings:
metalinter-output.txt

So I started to fix them.

@ianlancetaylor ianlancetaylor changed the title Improve encoding/xml package based on the suggestions from metalinter encoding/xml: improve package based on the suggestions from metalinter Aug 23, 2017

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Aug 23, 2017

Please do not send in changes merely to reduce the cyclomatic complexity, unless those changes clearly make the code more readable.

Note that some of the warnings in the doc seem simply incorrect.

Thanks.

@pazderak

This comment has been minimized.

Copy link
Contributor Author

pazderak commented Aug 23, 2017

Sure, will do. I was thinking about splitting of marshalStruct function to the separate functions based on the flags value, what do you think about?

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Aug 23, 2017

Change https://golang.org/cl/58210 mentions this issue: encoding/xml: improve package based on the suggestions from metalinter

@gopherbot gopherbot closed this in 6e9e9df Aug 24, 2017

@golang golang locked and limited conversation to collaborators Aug 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.