host header not suppressed for proxy connections

[gopherbot]

by jason@eggnet.com:

the (*Request).write() function does not conform to the documentation:

// If req.RawURL is non-empty, WriteProxy uses it unchanged
// instead of URL but still omits the Host: header.

The Host header should be suppressed if usingProxy is true.

Currently the Host header is unconditionally written to the request, which is easy to
see by inspection.  There is no if wrapped around fmt.Fprintf(bw, "Host:
%s\r\n", host)

Which revision are you using?  (hg identify)

b0819469a6df (release-branch.r60) release/release.r60

[bradfitz]

Comment 1:

This is just a documentation problem.  I'll fix the glitch.
Host headers are still required, even with proxies.  (that was a previous fix, but docs
weren't updated to match)

Owner changed to @bradfitz.

[rsc]

Comment 2:

Status changed to Accepted.

[gopherbot]

Comment 3 by jason@eggnet.com:

Interesting, thank you.

[bradfitz]

Comment 4:

This issue was closed by revision 7233dcd.

Status changed to Fixed.