Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: support for Bitbucket #23950

Closed
SamWhited opened this issue Feb 20, 2018 · 3 comments

Comments

@SamWhited
Copy link
Member

commented Feb 20, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

x/vgo fetched on 2018-02-30

What did you do?

$ git clone https://bitbucket.org/mellium/xmlstream.git
$ cd xmlstream
$ vgo build

What did you expect to see?

Deps zipfile downloaded using the Bitbucket API and build success.

What did you see instead?

vgo: resolving import "mellium.im/reader"
vgo: import "mellium.im/xmlstream" ->
        import "mellium.im/reader": unknown VCS, Repo: git, https://bitbucket.org/mellium/reader.git

Meta import looks like:

$ curl https://mellium.im/xmlstream?go-get=1
<meta name="go-import" content="mellium.im/xmlstream git https://bitbucket.org/mellium/xmlstream.git">

and it is fetchable with go get.

Since the vgo post says that it has special overrides to use the APIs for the hosting providers previously supported, I would expect this to detect that this is a Bitbucket URL and fetch a zip file using the API.

@gopherbot gopherbot added this to the Unreleased milestone Feb 20, 2018

@SamWhited

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2018

/cc @rsc

@rsc rsc changed the title x/vgo: fails when fetching git based deps from Bitbucket x/vgo: support for Bitbucket Feb 20, 2018

@rsc

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2018

Yes, we'll have to add support for all the other code hosting sites. I wanted to do Bitbucket before this morning's release but I ran out of time. If you want to give it a shot, see x/vgo/vendor/cmd/go/internal/modfetch/github.

My intent is to do all the ones that are special cases in the current go get.

@rsc rsc modified the milestones: Unreleased, vgo Feb 20, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Feb 20, 2018

Change https://golang.org/cl/95578 mentions this issue: cmd/go/internal/modfetch/bitbucket: fetch from bitbucket

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.