Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: import "github.com/Azure/azure-sdk-for-go": module source tree too big #25470

Closed
davidwalter0 opened this issue May 20, 2018 · 7 comments

Comments

@davidwalter0
Copy link

commented May 20, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version
go version go1.10.2 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/david/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build297679675=/tmp/go-build -gno-record-gcc-switches"

What did you do?

vgo get github.com/Azure/azure-sdk-for-go@v16.2.0

If possible, provide a recipe for reproducing the error.

vgo get github.com/Azure/azure-sdk-for-go@v16.2.0
vgo: downloading github.com/Azure/azure-sdk-for-go v0.0.0-20180503200013-52423c14f13e
vgo: import "github.com/Azure/azure-sdk-for-go": module source tree too big

A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

vgo: resolving import "github.com/Azure/azure-sdk-for-go"
vgo: finding github.com/Azure/azure-sdk-for-go 
vgo: adding github.com/Azure/azure-sdk-for-go

What did you see instead?

vgo get github.com/Azure/azure-sdk-for-go@v16.2.0
vgo: downloading github.com/Azure/azure-sdk-for-go v0.0.0-20180503200013-52423c14f13e
vgo: import "github.com/Azure/azure-sdk-for-go": module source tree too big

@gopherbot gopherbot added this to the vgo milestone May 20, 2018

@kardianos

This comment has been minimized.

Copy link
Contributor

commented May 20, 2018

This looks like a duplicate (or perhaps a variant) of #25424 .

@kardianos

This comment has been minimized.

Copy link
Contributor

commented May 20, 2018

The total files in the azure sdk is > 100MiB , mostly in the services directory. Some of this size appears to be caused by versioning service APIs by date, so probably a lot of duplicate code.

The question this raises is: should there be a max module size? If so, what should this max size be? Can it be overridden (say from an env var)?

@ncw

This comment has been minimized.

Copy link
Contributor

commented May 31, 2018

Is there a workaround for this? Unfortunately I've hit this brick wall in my first vgo adventure (with rclone)!

@kardianos

This comment has been minimized.

Copy link
Contributor

commented May 31, 2018

Right now I think the work around is to go get vgo, then adjust the 100 MiB limit to be higher.

@rsc What do you think should be done here? The options I see are to:

  • Make the limit higher and require packages to fall within it.
  • Keep the limit as-is, require the packages to pull down external resources or in Azure's case, actually version their API calls into separate modules.
  • Allow this limit to be set based on amount of RAM available.
  • Allow this limit to be overridden by an environment variable or similar.
@oiooj

This comment has been minimized.

Copy link
Member

commented Jun 6, 2018

Fixed by rsc.

@oiooj oiooj closed this Jun 6, 2018

@ncw

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

@oiooj do we have a commit or a CL so we can examine the fix?

@oiooj

This comment has been minimized.

Copy link
Member

commented Jun 6, 2018

@ncw , The change is CL 116355.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.