Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/go: skip checking of go-import meta tags if replace exists for custom domain #26749
Please answer these questions before submitting your issue. Thanks!
What did you do?
At the time of writing,
So I tried to side-step this by adding a number of replace directive to the Github VCSs where the respective modules map.
What did you expect to see?
I'd hoped to see that
What did you see instead?
Is it reasonable to assume that if I have a replace directive path that matches a require that there is no module root checking required? Custom domain or otherwise I guess (although in this case it is a custom domain)?
I seem to remember some discussion from Russ about this in an issue/CL, but might be mistaken in that.
Does this issue reproduce with the latest release (go1.10.3)?
n/a: testing with tip
Yes, but we still need to decide what version it is that we're replacing: if you require the current module from outside, it will still pick up a requirement at the original
Did you specify a version to be replaced in the
Perhaps we should assume pseudo-version
I should really have provided more context in my
The versions in the require directives are those that previously successfully resolved (unsurprisingly they match the commits in the description of this issue). But, and I think this is the point you are hinting at, it could equally be that these require directives did not previously exist.
As you can see, I'm using version-agnostic replace directives.
Possibly in the case that a require directive (I keep using that word "directive", is it correct??) doesn't already exist.