Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: use the commit message if there's exactly one #27312

Closed
mvdan opened this issue Aug 28, 2018 · 1 comment
Closed

x/build/cmd/gopherbot: use the commit message if there's exactly one #27312

mvdan opened this issue Aug 28, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@mvdan
Copy link
Member

mvdan commented Aug 28, 2018

Time and time again, I see contributors updating their commit messages on their PRs, instead of updating the PR title and body. I can understand that - it's more intuitive, it can be done very easily with git, and it mirrors what people do with Github and Gerrit.

However, gopherbot does the opposite - it ignores the actual commit messages, but uses the PR title and body. This is can be good for newcomers, especially those who aren't used to squashing commits.

The result is that we end up wasting time every week, when contributors get stuck fighting gopherbot. This just happened again: https://go-review.googlesource.com/c/go/+/126897

I propose that the PR title and body be only used if there are many commits. Otherwise, the single's commit message should be used.

cc @andybons @bradfitz @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 28, 2018
@mvdan
Copy link
Member Author

mvdan commented Aug 28, 2018

I just realised this should be a comment on #25359, but I failed to find the issue. Will close and comment there.

@mvdan mvdan closed this as completed Aug 28, 2018
@golang golang locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants