Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/cmd/go-contrib-init: requires scratch repo to be set up as x/scratch #28332
In previous Go Contributor Workshops, I had attendees run the following:
However, that's tedious and not particularly portable. For example, it doesn't work with environments that use a multi-path GOPATH. So, since @kevinburke graciously set up a memorable domain name for it, I've tried to update the instructions to be the following:
However, that doesn't work, as
It's been decided that
I think it should accept any directory for it under GOPATH. Or, once we convert the subrepos to modules, the GOPATH directory check should be removed entirely.
Did you mean "as x/scratch" in the title?
I think there's still value in pretending scratch would live at
I agree that the experience for users should be good, so we should look for a way to improve the situation.
It doesn't seem very tedious to me, compared to all the other steps that need to be taken while contributing.
However, it shouldn't fail if a person has a valid GOPATH list containing more than one directory in it.
Given they've already done
What do you think?
That's sort of my point. For every other repo, one can
The scratch repo already is a special case, so I'm not sure that this is a valid point.
I think this just ends up confusing newcomers. They try
That's a tiny bit better, but still leaves me with complex instructions for what should be trivial.
Ideally, once all of these repos are modules, we're just going to do:
However, I understand that the x repos aren't going to get modules anytime soon, so I'm looking for a short-term improvement.