Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
os: remove 5ms exec sleep on Windows #28371
// NOTE(brainman): It seems that sometimes process is not dead // when WaitForSingleObject returns. But we do not know any // other way to wait for it. Sleeping for a while seems to do // the trick sometimes. So we will sleep and smell the roses. defer time.Sleep(5 * time.Millisecond)
That is unfortunate.
But we don't support Windows XP anymore, so maybe we can remove it now?
But I forget everything about Windows I had learned while researching that patch, so opening this bug instead.