Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: remove 5ms exec sleep on Windows #28371

Closed
bradfitz opened this issue Oct 24, 2018 · 2 comments
Closed

os: remove 5ms exec sleep on Windows #28371

bradfitz opened this issue Oct 24, 2018 · 2 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 24, 2018

src/os/exec_windows.go contains in its (*Process).wait method:

	// NOTE(brainman): It seems that sometimes process is not dead
	// when WaitForSingleObject returns. But we do not know any
	// other way to wait for it. Sleeping for a while seems to do
	// the trick sometimes. So we will sleep and smell the roses.
	defer time.Sleep(5 * time.Millisecond)

That is unfortunate.

I tried to remove it on https://go-review.googlesource.com/c/go/+/84175 specifically for debugging Windows XP problems (#2866 and #17245), and it apparently didn't work.

But we don't support Windows XP anymore, so maybe we can remove it now?

But I forget everything about Windows I had learned while researching that patch, so opening this bug instead.

/cc @alexbrainman @jordanrh1

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Oct 25, 2018

You had opened the exact same bug here - #25965. An oversight perhaps ?

@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Oct 25, 2018

@agnivade, ah, thanks! Closing this one.

@bradfitz bradfitz closed this Oct 25, 2018
@golang golang locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.