Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: goimports should support -s flag for compatibility with gofmt #28588

Closed
eklitzke opened this issue Nov 4, 2018 · 1 comment
Milestone

Comments

@eklitzke
Copy link
Contributor

@eklitzke eklitzke commented Nov 4, 2018

What version of Go are you using (go version)?

$ go version
go version go1.11 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/evan/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/evan/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/golang"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build466236096=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Tried to use goimports -s

What did you expect to see?

The goimports flag should work with the -s flag, as gofmt does.

What did you see instead?

$ goimports -s
flag provided but not defined: -s
@gopherbot gopherbot added this to the Unreleased milestone Nov 4, 2018
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 5, 2018

We declined this previously in #8759 and updated the docs in golang/tools@7d47e84

It does not aim to be a drop-in replacement. All tools do not need to do all things.

@bradfitz bradfitz closed this Nov 5, 2018
@golang golang locked and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.