cmd/trace: TestAnalyzeAnnotations failing for some users

[jerrinsg]

What version of Go are you using (go version)?

$ go version
go version devel +e496e612b7 Fri Nov 9 21:47:48 2018 +0000 linux/amd64

Does this issue reproduce with the latest release?

I am seeing this issue on the master branch

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
$ ./../bin/go env                                                                                                                                                                                         ‹system›
GOARCH="amd64"
GOBIN=""
GOCACHE="~/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jerrin/gocode"
GOPROXY=""
GORACE=""
GOROOT="/work/temp/go"
GOTMPDIR=""
GOTOOLDIR="/work/temp/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build564641832=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Ran all.bash test suite

What did you expect to see?

All tests passing

What did you see instead?

--- FAIL: TestAnalyzeAnnotations (0.01s)
    annotations_test.go:101: failed to trace the program: 16: running before start [g:0 p:1 ProcStart/5 [3 0 0] [] 2445 ->0]
--- FAIL: TestAnalyzeAnnotationGC (0.01s)
    annotations_test.go:271: failed to trace the program: unexpected 18:[g:0 p:0 ProcStop/6 [0 0 0] [] 2c23 ->0] [true 23 <nil> <nil>]
FAIL
FAIL	cmd/trace	0.066s

Full set of logs - test.log

[bradfitz]

What version of Linux? You running on bare metal, in a VM on your desktop, on a cloud provider?

[bradfitz]

/cc @aclements

[jerrinsg]

I ran this on a bare metal Ubuntu 18.04.1 LTS (desktop version)

$ uname -a
Linux Precision-T3610 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

I can reliably reproduce the issue on this machine.

But the tests run without any issue on another Ubuntu VM running Ubuntu 18.04.1 LTS (GNU/Linux 4.15.0-38-generic x86_64) (server version) ...

[hyangah]

@jerrinsg We recently reverted some of the recent changes in trace parser. Do you still observe the test failures with tip?

[jerrinsg]

I don't see the test failures after pulling in the latest changes (at 2140975 cmd/compile: eliminate write barriers when writing non-heap ptrs).

I do see the failures when I go back to commit e496e61 runtime: never call into race detector with retaken P

[hyangah]

I guess golang.org/cl/150517 that reverted the trace parser change fixed this issue. ( 6d5caf3)