Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.10] #29236

Closed
FiloSottile opened this issue Dec 13, 2018 · 2 comments
Closed

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Dec 13, 2018

This is a tracking issue for #29231, a security vulnerability fixed in Go 1.10.6.

@FiloSottile FiloSottile added this to the Go1.10.6 milestone Dec 13, 2018
@geek1011

This comment has been minimized.

Copy link

@geek1011 geek1011 commented Dec 13, 2018

This breaks go getting with ...: https://travis-ci.com/geek1011/kobopatch-patches/builds/94712529#L523.

This is because you just do a simple check for if a path contains .., without accounting for the ....

@FiloSottile FiloSottile changed the title cmd/go: directory traversal via curly braces in import paths [Go 1.10] cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.10] Dec 13, 2018
@FiloSottile

This comment has been minimized.

Copy link
Member Author

@FiloSottile FiloSottile commented Dec 13, 2018

Thanks for reporting this, I opened #29241 and we'll work to fix this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.