New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: math/big: Rat.SetUint64 #29579

Open
TuomLarsen opened this Issue Jan 5, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@TuomLarsen
Copy link

TuomLarsen commented Jan 5, 2019

Please consider adding Rat.SetUint64 in addition to Rat.SetInt64 as there is currently no way of setting by uint64 integers. This is similar to Int.SetInt64 and Int.SetUint64.

@gopherbot gopherbot added this to the Proposal milestone Jan 5, 2019

@gopherbot gopherbot added the Proposal label Jan 5, 2019

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Jan 9, 2019

Go 1 had Rat.SetInt64 and Int.SetInt64, but then Go 1.1 added Int.SetUint64. At the time we clearly forgot about Rat. This seems fine, and @griesemer agrees.

@rsc rsc modified the milestones: Proposal, Go1.13 Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment