Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress/gzip: clarify that Multistream gzip requires a ByteReader #30284

Closed
wants to merge 1 commit into from
Closed

compress/gzip: clarify that Multistream gzip requires a ByteReader #30284

wants to merge 1 commit into from

Conversation

pbnjay
Copy link
Contributor

@pbnjay pbnjay commented Feb 17, 2019

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 17, 2019
@gopherbot
Copy link

This PR (HEAD: 560cc37) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/162999 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Joe Tsai:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 9c617c1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/162999 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Jeremy Jay:

Patch Set 2:

(2 comments)

Thanks!


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

@pbnjay pbnjay changed the title compress/gzip: clarify that Multistream gzip requires a ByteReader. compress/gzip: clarify that Multistream gzip requires a ByteReader Feb 18, 2019
@gopherbot
Copy link

Message from Jeremy Jay:

Patch Set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Joe Tsai:

Patch Set 4: Run-TryBot+1 Code-Review+2

Thanks for the doc clarification!


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a713e602


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/162999.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 26, 2019
Change-Id: Ib24778f3172c011e6a39ee65dce8764f3cc911ea
GitHub-Last-Rev: 9c617c1
GitHub-Pull-Request: #30284
Reviewed-on: https://go-review.googlesource.com/c/162999
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/162999 has been merged.

@gopherbot gopherbot closed this Feb 26, 2019
@pbnjay pbnjay deleted the patch-1 branch March 6, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants