Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestLookupHostCancel flake on windows-*-2008 #31950

Closed
bradfitz opened this issue May 9, 2019 · 3 comments
Closed

net: TestLookupHostCancel flake on windows-*-2008 #31950

bradfitz opened this issue May 9, 2019 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bradfitz
Copy link
Contributor

bradfitz commented May 9, 2019

https://storage.googleapis.com/go-build-log/0d2b5de5/windows-386-2008_9f28007e.log

--- FAIL: TestLookupHostCancel (0.95s)
    lookup_test.go:957: LookupHost("invalid.invalid"): failed with unexpected error: lookup invalid.invalid: no such host
FAIL
FAIL	net	10.235s
2019/05/09 21:20:11 Failed: exit status 1
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 9, 2019
@bradfitz bradfitz added this to the Go1.13 milestone May 9, 2019
@bcmills bcmills changed the title net: TestLookupHostCancel flake on windows-386-2008 net: TestLookupHostCancel flake on windows-*-2008 May 14, 2019
@bcmills
Copy link
Contributor

bcmills commented May 14, 2019

https://build.golang.org/log/a0942577b43d53e2151de88f26b4474e505d75c9

--- FAIL: TestLookupHostCancel (0.72s)
    lookup_test.go:957: LookupHost("invalid.invalid"): failed with unexpected error: lookup invalid.invalid: no such host
FAIL
FAIL	net	8.429s

@bradfitz
Copy link
Contributor Author

Hah, in lookup_windows.go:

func (r *Resolver) lookupIP(ctx context.Context, network, name string) ([]IPAddr, error) { 
        // TODO(bradfitz,brainman): use ctx more. See TODO below.

Anyway, sent CL 177038 that'll fix this test.

@gopherbot
Copy link

Change https://golang.org/cl/177038 mentions this issue: net: check for canceled context before starting Windows DNS lookup

@bcmills bcmills mentioned this issue Apr 30, 2020
Closed
@golang golang locked and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@bradfitz @bcmills @gopherbot