Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: fix global @item test namespace #32637

Open
muirdm opened this issue Jun 16, 2019 · 0 comments
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Jun 16, 2019

Currently the gopls completion tests use a global namespace for the @item marks. This is annoying because when adding a new testdata package you have to be careful to use globally unique names for all your test completion items. @ianthehat has a plan to transition to package (or file?) local namespaces.

@gopherbot gopherbot added this to the Unreleased milestone Jun 16, 2019
@gopherbot gopherbot added the gopls label Jun 16, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.