Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: fix global @item test namespace #32637

muirdm opened this issue Jun 16, 2019 · 1 comment

x/tools/gopls: fix global @item test namespace #32637

muirdm opened this issue Jun 16, 2019 · 1 comment


Copy link

@muirdm muirdm commented Jun 16, 2019

Currently the gopls completion tests use a global namespace for the @item marks. This is annoying because when adding a new testdata package you have to be careful to use globally unique names for all your test completion items. @ianthehat has a plan to transition to package (or file?) local namespaces.

@gopherbot gopherbot added this to the Unreleased milestone Jun 16, 2019
@gopherbot gopherbot added the gopls label Jun 16, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
@stamblerre stamblerre modified the milestones: Unreleased, gopls unplanned Dec 4, 2019
@stamblerre stamblerre added the Testing label Jan 13, 2020
@stamblerre stamblerre modified the milestones: gopls unplanned, gopls testing, Unreleased Jan 29, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
Copy link

@stamblerre stamblerre commented Aug 6, 2020

We also just ran into the issue that the framework does not complain about markers with the same name.

@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants