Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: dns host should be case insensitive in tests #34781

Closed
mengzhuo opened this issue Oct 9, 2019 · 4 comments
Closed

net: dns host should be case insensitive in tests #34781

mengzhuo opened this issue Oct 9, 2019 · 4 comments

Comments

@mengzhuo
Copy link
Contributor

@mengzhuo mengzhuo commented Oct 9, 2019

According to rfc4343:

Each node in the DNS tree has a name consisting
   of zero or more labels [STD13, RFC1591, RFC2606] that are treated in
   a case insensitive fashion. 

What version of Go are you using (go version)?

$ go version
https://github.com/golang/go/commit/2197321db1dd997165c0091ba2bcb3b6be7633d0

Does this issue reproduce with the latest release?

Yes

What did you do?

https://build.golang.org/log/47cd658d0b040490e53ec53dc82e0032f0165b99

What did you expect to see?

ALL TESTES PASSED

What did you see instead?

--- FAIL: TestLookupGmailMX (0.02s)
    lookup_test.go:151: got &{gmail-smtp-in.l.google.COM. 5}; want a record containing google.com.
    lookup_test.go:151: got &{alt1.gmail-smtp-in.l.google.COM. 10}; want a record containing google.com.
    lookup_test.go:151: got &{alt2.gmail-smtp-in.l.google.COM. 20}; want a record containing google.com.
    lookup_test.go:151: got &{alt3.gmail-smtp-in.l.google.COM. 30}; want a record containing google.com.
    lookup_test.go:151: got &{alt4.gmail-smtp-in.l.google.COM. 40}; want a record containing google.com.
@odeke-em
Copy link
Member

@odeke-em odeke-em commented Oct 9, 2019

Thank you for this report @mengzhuo! So we have a recently closed issue #34446, fixed by CL https://golang.org/cl/196801 which was for case insensitivity of net.TestLookupGmailNS. /cc @bradfitz

@bradfitz bradfitz added this to the Unplanned milestone Oct 9, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 10, 2019

Change https://golang.org/cl/200277 mentions this issue: net: use case-insensitive host string comparison in TestLookup*

@Sehsyha
Copy link

@Sehsyha Sehsyha commented Oct 11, 2019

Can I take a look at this one ?

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 11, 2019

@Sehsyha Thanks, but the previous comment says that a patch has already been sent for this issue.

@gopherbot gopherbot closed this in 592d304 Oct 12, 2019
@golang golang locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.