Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: variadic completion ranking incorrect with interfaces #35625

Closed
stamblerre opened this issue Nov 15, 2019 · 1 comment
Closed
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

Simplified repro:

var cphs []source.CheckPackageHandle
var handles []*checkPackageHandle
for _, x := range handles {
    cphs = append(cphs, <>)
}

I got a suggestion for cphs... above x. This is probably because *checkPackageHandle only implements source.CheckPackageHandle.

/cc @muirdm

@gopherbot gopherbot added this to the Unreleased milestone Nov 15, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/207518 mentions this issue: internal/lsp: fix variadic interface completion ranking

@golang golang locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants