Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: variadic completion ranking incorrect with interfaces #35625

Closed
stamblerre opened this issue Nov 15, 2019 · 1 comment
Closed

x/tools/gopls: variadic completion ranking incorrect with interfaces #35625

stamblerre opened this issue Nov 15, 2019 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 15, 2019

Simplified repro:

var cphs []source.CheckPackageHandle
var handles []*checkPackageHandle
for _, x := range handles {
    cphs = append(cphs, <>)
}

I got a suggestion for cphs... above x. This is probably because *checkPackageHandle only implements source.CheckPackageHandle.

/cc @muirdm

@gopherbot gopherbot added this to the Unreleased milestone Nov 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 16, 2019

Change https://golang.org/cl/207518 mentions this issue: internal/lsp: fix variadic interface completion ranking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.